Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/115 disable ga4 custom dimensions #116

Merged
merged 18 commits into from
Oct 30, 2023

Conversation

bharatpareek
Copy link
Contributor

Fixes #115

Describe the Approach

  • At first I added logic in the backend so if GA4 was selected as the option, the dimension fields will not even render on the frontend.
  • The issue with that is when user changes the analytics type to something other than GA$, the fields won't still show as they were not rendered.
  • So I went with JS approach, added classes to the table markup on settings API, to identify fields.
  • Handled field visibility on analyticstype field change event.

Need to confirm if the JS should move to a new file and we create a new entry point in webpack. @Tonnie-Exelero

@bharatpareek
Copy link
Contributor Author

There are some issues with PHPCS not working properly, figuring that out.

@mehigh mehigh merged commit 8a5bf13 into master Oct 30, 2023
1 check passed
@mehigh mehigh deleted the feature/115-disable-ga4-custom-dimensions branch October 30, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable custom dimensions for GA4
2 participants